Changeset 0f17bff in mainline for kernel/arch/ia32/src/userspace.c

Timestamp:

2016-05-05T08:34:45Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

811770c

Parents:

4b0206c

Message:

Replace magic numbers with macros

File:

• kernel/arch/ia32/src/userspace.c (modified) (4 diffs)

kernel/arch/ia32/src/userspace.c

@@ -39 +39 @@
 #include <abi/proc/uarg.h>
 #include <mm/as.h>
+#include <arch/cpu.h>
+#include <arch/asm.h>
 
 /** Enter userspace
@@ -47 +49 @@
 void userspace(uspace_arg_t *kernel_uarg)
 {
-        ipl_t ipl = interrupts_disable();
+        uint32_t eflags = read_eflags();
         
         asm volatile (
-                /*
-                 * Clear nested task flag.
-                 */
-                "pushfl\n"
-                "pop %%eax\n"
-                "and $0xffffbfff, %%eax\n"
-                "push %%eax\n"
-                "popfl\n"
-                
                 /* Set up GS register (virtual register segment) */
                 "movl %[vreg_des], %%gs\n"
@@ -64 +57 @@
                 "pushl %[udata_des]\n"
                 "pushl %[stack_top]\n"
-                "pushl %[ipl]\n"
+                "pushl %[eflags]\n"
                 "pushl %[utext_des]\n"
                 "pushl %[entry]\n"
@@ -74 +67 @@
                 "iret\n"
                 :
-                : [udata_des] "i" (GDT_SELECTOR(UDATA_DES) | PL_USER),
+                : [eflags_mask] "i" (~EFLAGS_NT),
+                  [udata_des] "i" (GDT_SELECTOR(UDATA_DES) | PL_USER),
                   [stack_top] "r" ((uint8_t *) kernel_uarg->uspace_stack +
                       kernel_uarg->uspace_stack_size),
-                  [ipl] "r" (ipl),
+                  [eflags] "r" ((eflags & ~(EFLAGS_NT)) | EFLAGS_IF),
                   [utext_des] "i" (GDT_SELECTOR(UTEXT_DES) | PL_USER),
                   [entry] "r" (kernel_uarg->uspace_entry),