Changeset 0f17bff in mainline for kernel/arch/ia32/src/asm.S

Timestamp:

2016-05-05T08:34:45Z (8 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

811770c

Parents:

4b0206c

Message:

Replace magic numbers with macros

File:

• kernel/arch/ia32/src/asm.S (modified) (3 diffs)

kernel/arch/ia32/src/asm.S

@@ -36 +36 @@
 #include <arch/mm/page.h>
 #include <arch/istate_struct.h>
+#include <arch/smp/apic.h>
 
 .text
@@ -110 +111 @@
 FUNCTION_BEGIN(paging_on)
         movl %cr0, %edx
-        orl $(1 << 31), %edx  /* paging on */
+        orl $CR0_PG, %edx  /* paging on */
         
         /* Clear Cache Disable and not Write Though */
-        andl $~((1 << 30) | (1 << 29)), %edx
+        andl $~(CR0_CD | CR0_NW), %edx
         movl %edx, %cr0
         jmp 0f
@@ -127 +128 @@
  */
 FUNCTION_BEGIN(enable_l_apic_in_msr)
-        movl $0x1b, %ecx
+        movl $IA32_MSR_APIC_BASE, %ecx
         rdmsr
-        orl $(1 << 11), %eax
-        orl $(0xfee00000), %eax
+        orl $(L_APIC_BASE | IA32_APIC_BASE_GE), %eax
         wrmsr
         ret