Changeset 0a3fbc7 in mainline for uspace/srv/net/nil/eth/eth.c

Timestamp:

2010-10-27T21:47:02Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e9caf47, f2d2c604

Parents:

03649d8

Message:

Do not leak eth_globals.broadcast_addr in case of a failure.

File:

• uspace/srv/net/nil/eth/eth.c (modified) (1 diff)

uspace/srv/net/nil/eth/eth.c

@@ -211 +211 @@
                 goto out;
         }
-        if (ERROR_OCCURRED(eth_devices_initialize(&eth_globals.devices)))
+        if (ERROR_OCCURRED(eth_devices_initialize(&eth_globals.devices))) {
+                free(eth_globals.broadcast_addr);
                 goto out;
-        if (ERROR_OCCURRED(eth_protos_initialize(&eth_globals.protos)))
+        }
+        if (ERROR_OCCURRED(eth_protos_initialize(&eth_globals.protos))) {
+                free(eth_globals.broadcast_addr);
                 eth_devices_destroy(&eth_globals.devices);
+        }
 out:
         fibril_rwlock_write_unlock(&eth_globals.protos_lock);