Changeset 09d01f2 in mainline for kernel/generic/src/ipc/ops/conctmeto.c

Timestamp:

2017-12-18T17:40:52Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2024096, 23d4515

Parents:

6a32cc5f

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-18 15:39:01)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2017-12-18 17:40:52)

Message:

Return phones/capabilities separately from error codes.

File:

• kernel/generic/src/ipc/ops/conctmeto.c (modified) (2 diffs)

kernel/generic/src/ipc/ops/conctmeto.c

@@ -42 +42 @@
 static int request_preprocess(call_t *call, phone_t *phone)
 {
-        cap_handle_t phone_handle = phone_alloc(TASK);
+        cap_handle_t phone_handle;
+        int rc = phone_alloc(TASK, &phone_handle);
 
-        /* Remember the phone capability or the error. */
-        call->priv = phone_handle;
-        if (phone_handle < 0)
-                return phone_handle;
+        /* Remember the phone capability or that an error occured. */
+        call->priv = (rc == EOK) ? phone_handle : -1;
+
+        if (rc != EOK) {
+                return rc;
+        }
 
         /* Set arg5 for server */
@@ -61 +64 @@
 {
         cap_handle_t phone_handle = (cap_handle_t) call->priv;
+
+        if (phone_handle < 0) {
+                return EOK;
+        }
+
         phone_dealloc(phone_handle);
         /* Hand over reference from ARG5 to phone->kobject */