Changeset 0800b26 in mainline

Timestamp:

2020-05-06T10:30:30Z (4 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7a34f87d, 807be7e

Parents:

ccbd2e1

Message:

Do not leak exchanges in udebug client API

File:

• uspace/lib/c/generic/udebug.c (modified) (11 diffs)

uspace/lib/c/generic/udebug.c

@@ -42 +42 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_1_0(exch, IPC_M_DEBUG, UDEBUG_M_BEGIN);
+        errno_t rc = async_req_1_0(exch, IPC_M_DEBUG, UDEBUG_M_BEGIN);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -48 +51 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_1_0(exch, IPC_M_DEBUG, UDEBUG_M_END);
+        errno_t rc = async_req_1_0(exch, IPC_M_DEBUG, UDEBUG_M_END);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -54 +60 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_2_0(exch, IPC_M_DEBUG, UDEBUG_M_SET_EVMASK, mask);
+        errno_t rc = async_req_2_0(exch, IPC_M_DEBUG, UDEBUG_M_SET_EVMASK, mask);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -65 +74 @@
         errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_THREAD_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
+        async_exchange_end(exch);
 
         *copied = (size_t) a_copied;
@@ -80 +90 @@
         errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_NAME_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
+        async_exchange_end(exch);
 
         *copied = (size_t) a_copied;
@@ -95 +106 @@
         errno_t rc = async_req_3_3(exch, IPC_M_DEBUG, UDEBUG_M_AREAS_READ,
             (sysarg_t) buffer, n, NULL, &a_copied, &a_needed);
+        async_exchange_end(exch);
 
         *copied = (size_t) a_copied;
@@ -105 +117 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_4_0(exch, IPC_M_DEBUG, UDEBUG_M_MEM_READ,
+        errno_t rc = async_req_4_0(exch, IPC_M_DEBUG, UDEBUG_M_MEM_READ,
             (sysarg_t) buffer, addr, n);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -112 +127 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_3_0(exch, IPC_M_DEBUG, UDEBUG_M_ARGS_READ,
+        errno_t rc = async_req_3_0(exch, IPC_M_DEBUG, UDEBUG_M_ARGS_READ,
             tid, (sysarg_t) buffer);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -119 +137 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_3_0(exch, IPC_M_DEBUG, UDEBUG_M_REGS_READ,
+        errno_t rc = async_req_3_0(exch, IPC_M_DEBUG, UDEBUG_M_REGS_READ,
             tid, (sysarg_t) buffer);
+        async_exchange_end(exch);
+
+        return rc;
 }
 
@@ -131 +152 @@
         errno_t rc = async_req_2_3(exch, IPC_M_DEBUG, UDEBUG_M_GO,
             tid, &a_ev_type, val0, val1);
+        async_exchange_end(exch);
 
         *ev_type = a_ev_type;
@@ -139 +161 @@
 {
         async_exch_t *exch = async_exchange_begin(sess);
-        return async_req_2_0(exch, IPC_M_DEBUG, UDEBUG_M_STOP, tid);
+        errno_t rc = async_req_2_0(exch, IPC_M_DEBUG, UDEBUG_M_STOP, tid);
+        async_exchange_end(exch);
+
+        return rc;
 }