Changeset 01900b6 in mainline for uspace/lib/c/generic/loader.c

Timestamp:

2020-01-21T15:10:26Z (4 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

51da086

Parents:

f8fb03b

Message:

Use an optional output argument instead of errno to propagate the error

The use of errno is troublesome in all other than top-level library
functions since the value in errno might get overwritten by subsequent
inner calls on the error path (e.g. cleanup, deallocation, etc.). The
optional output argument makes it possible to explicitly ignore the
error code if it is not needed, but still to pass it reliably back to
the original caller.

This change affecs async_connect_me_to(),
async_connect_me_to_blocking(), async_connect_kbox(), service_connect(),
service_connect_blocking() and loader_connect().

File:

• uspace/lib/c/generic/loader.c (modified) (3 diffs)

uspace/lib/c/generic/loader.c

@@ -46 +46 @@
 #include "private/loader.h"
 
-/** Connect to a new program loader.
- *
- * Spawns a new program loader task and returns the connection structure.
+/** Spawn a new program loader.
+ *
+ * Spawn a new program loader task. The loader then independetly
+ * connects to the naming service.
  *
  * @param name Symbolic name to set on the newly created task.
  *
  * @return Error code.
+ *
  */
 errno_t loader_spawn(const char *name)
@@ -60 +62 @@
 }
 
-loader_t *loader_connect(void)
+/** Connect to a program loader.
+ *
+ * @param rc Placeholder for return code. Unused if NULL.
+ *
+ * @return Loader structure.
+ *
+ */
+loader_t *loader_connect(errno_t *rc)
 {
         loader_t *ldr = malloc(sizeof(loader_t));
@@ -67 +76 @@
 
         async_sess_t *sess =
-            service_connect_blocking(SERVICE_LOADER, INTERFACE_LOADER, 0);
+            service_connect_blocking(SERVICE_LOADER, INTERFACE_LOADER, 0, rc);
         if (sess == NULL) {
                 free(ldr);